Skip to content

fix(KustomizeUpdater): non docker.io image registries were ignored for image updates#2011

Merged
oleksandr-codefresh merged 16 commits into
release/2026.2from
osaulyak/YOS-368-kustomize-image-registry-2
Jun 17, 2026
Merged

fix(KustomizeUpdater): non docker.io image registries were ignored for image updates#2011
oleksandr-codefresh merged 16 commits into
release/2026.2from
osaulyak/YOS-368-kustomize-image-registry-2

Conversation

@oleksandr-codefresh

@oleksandr-codefresh oleksandr-codefresh commented Jun 11, 2026

Copy link
Copy Markdown

Fix for issue:

Update Argo CD Application Image Tags for kustomize apps does commit any changes during deployment if image pushed to non-default registry ( docker.io )

images:
  - name: vplakydatestregistry.azurecr.io/xeonalex/guesbook-unprivileged
    newTag: "latest"

⚠️ Does this change require a corresponding Server Change?
⚠️ If so - please add a "Requires Server Change" label to this PR!

@rain-on rain-on self-requested a review June 11, 2026 05:23
@oleksandr-codefresh

oleksandr-codefresh commented Jun 11, 2026

Copy link
Copy Markdown
Author

@rain-on Based on your comment #2008 (comment)
I decided to go only with .Reference.FriendlyName() as it's much simpler.
Refactoring into HashSet<ContainerImageReference> require quite deep knowledge in these areas.

rain-on
rain-on approved these changes Jun 12, 2026
View reviewed changes

@rain-on rain-on left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oleksandr-codefresh
oleksandr-codefresh commented Jun 16, 2026
View reviewed changes
Comment thread source/Calamari.Tests/ArgoCD/KustomizeUpdaterTests.cs
@rain-on rain-on self-requested a review June 16, 2026 04:48
ATGardner
ATGardner reviewed Jun 16, 2026
View reviewed changes
Comment thread source/Calamari/ArgoCD/JsonPatchImageReplacer.cs Outdated
ATGardner
ATGardner reviewed Jun 16, 2026
View reviewed changes
Comment thread source/Calamari/ArgoCD/YamlJson6902PatchImageReplacer.cs Outdated
rain-on
rain-on approved these changes Jun 17, 2026
View reviewed changes

@rain-on rain-on left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - also great that we go some other eyes on it for info-sharing 🙏

@oleksandr-codefresh oleksandr-codefresh merged commit 5d78b67 into release/2026.2 Jun 17, 2026
31 checks passed
@oleksandr-codefresh oleksandr-codefresh deleted the osaulyak/YOS-368-kustomize-image-registry-2 branch June 17, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ATGardner ATGardner ATGardner approved these changes

@rain-on rain-on rain-on approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-codefresh @ATGardner @rain-on